feat: support valkey #1488
feat: support valkey #1488
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1488 +/- ##
===========================================
- Coverage 100.00% 99.92% -0.08%
===========================================
Files 31 31
Lines 2530 2539 +9
Branches 432 432
===========================================
+ Hits 2530 2537 +7
- Misses 0 2 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I checked it late. Tomorrow, I will check the point where the error occurred and try to make sure the tests pass. However, since I am using WSL, it might be difficult to run tests locally. |
phi-friday
force-pushed
the
feat-support-valkey
branch
from
6c52747 to
a8470ce
Compare
|
It looks like PR #1479 also encountered errors only in the macOS tests, just like this PR, and the same error occurred in the same test. It seems there is nothing for me to fix except for formatting. |
|
@miguelgrinberg |
|
@phi-friday I'll have a look at this as soon as I can. The main thing that is missing is to restore full coverage, but I can take a look at this myself. Thanks! |
|
@phi-friday Merged! Thank you for your patience. I'll spend a bit of time trying to figure out the build failures on Mac, and then I'll issue a new release with this change. Thank you! |
closes: #1428
It has been half a year since the issue was raised, but I noticed that no related PR has been created, so I gave it a try.
I believe I made minimal changes, and I expect this will remain valid unless the APIs of Valkey and Redis change drastically.